Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fields Modification for Subcontracting DocTypes #42383

Conversation

Ninad1306
Copy link
Contributor

@Ninad1306 Ninad1306 commented Jul 18, 2024

Current Issues:

  • All fields in both Subcontracting Order and Subcontracting Receipt are currently organized under a single tab which is less user-friendly and harder to navigate.

  • And field labels related to Supplier in subcontracting doctypes should be Job Worker, to accurately reflect the role in the subcontracting process.

After Changes:

  • Subcontracting Receipt

image

  • Subcontracting Order

image

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jul 18, 2024
@Ninad1306 Ninad1306 marked this pull request as draft July 18, 2024 07:55
@Ninad1306 Ninad1306 marked this pull request as ready for review July 18, 2024 09:44
@rohitwaghchaure rohitwaghchaure merged commit 3023399 into frappe:develop Jul 25, 2024
20 checks passed
mergify bot pushed a commit that referenced this pull request Jul 25, 2024
* fix: fields renaming and reordering for enhanced user experience

* fix: dashboard data for stock entry

(cherry picked from commit 3023399)

# Conflicts:
#	erpnext/subcontracting/doctype/subcontracting_order/subcontracting_order.json
vorasmit added a commit that referenced this pull request Jul 26, 2024
…-42383

fix: Fields Modification for Subcontracting DocTypes (backport #42383)
frappe-pr-bot pushed a commit that referenced this pull request Jul 31, 2024
## [15.31.3](v15.31.2...v15.31.3) (2024-07-31)

### Bug Fixes

* Adjust initial month's depreciation to end of depreciation period ([9d2ef4d](9d2ef4d))
* builtins.KeyError: ('ABC', 'Store - CP') (backport [#42505](#42505)) ([#42509](#42509)) ([f25b38c](f25b38c))
* consider payment entries for checking if tds is deducted ([183ac41](183ac41))
* dynamic condition in the pricing rule not working (backport [#42467](#42467)) ([#42495](#42495)) ([ac2ef21](ac2ef21))
* field_type is small text for v15 ([9e99eda](9e99eda))
* fields alteration related to subcontracting ([80d4dc2](80d4dc2))
* Fields Modification for Subcontracting DocTypes ([#42383](#42383)) ([422824b](422824b))
* ignore duplicates while creating default templates ([aea8271](aea8271))
* incorrect cost_center on AR/AP report ([0c2e948](0c2e948))
* incorrect current qty for the batch in stock reco (backport [#42434](#42434)) ([#42459](#42459)) ([298a569](298a569))
* keyerror posting_time (backport [#42452](#42452)) ([#42460](#42460)) ([2d2140a](2d2140a))
* not able to save BOM Creator ([#42540](#42540)) ([61280e6](61280e6))
* parenttype in item wise purchase and sales register ([322fbe9](322fbe9))
* performance issue for the report Purchase Order Analysis report (backport [#42503](#42503)) ([#42507](#42507)) ([edf1fcb](edf1fcb))
* price_list_currency not found error (backport [#42534](#42534)) ([#42539](#42539)) ([5fa185d](5fa185d))
* purchase return from rejected warehouse (backport [#42531](#42531)) ([#42535](#42535)) ([b7d70ac](b7d70ac))
* set pos data if not return doc ([25fe08e](25fe08e))
* **tests:** added tests for usecase ([1390c86](1390c86))
* warehouse filter in Product Bundle Balance (backport [#42532](#42532)) ([#42537](#42537)) ([826577c](826577c))
* Warranty Expiry Date not set in the serial number (backport [#42513](#42513)) ([#42515](#42515)) ([fc0db19](fc0db19))

### Performance Improvements

* huge number of serial no creation (backport [#42522](#42522)) ([#42544](#42544)) ([6840f6c](6840f6c))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants